-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(options): remove common options between the issues and PRs #586
Merged
luketomlinson
merged 11 commits into
actions:main
from
C0ZEN:feature/split-pr-and-issue-options
Oct 19, 2021
Merged
feat(options): remove common options between the issues and PRs #586
luketomlinson
merged 11 commits into
actions:main
from
C0ZEN:feature/split-pr-and-issue-options
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The option ignore-updates was removed
BREAKING CHANGE: The option exempt-all-assignees was removed
BREAKING CHANGE: The option exempt-assignees was removed
BREAKING CHANGE: The option exempt-all-milestones was removed
BREAKING CHANGE: The option exempt-milestones was removed
BREAKING CHANGE: The option any-of-labels was removed
BREAKING CHANGE: The option only-labels was removed
BREAKING CHANGE: The option only-labels was removed
BREAKING CHANGE: The option days-before-stale was removed
BREAKING CHANGE: The option remove-stale-when-updated was removed
8db9046
to
6700440
Compare
luketomlinson
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @C0ZEN this is great
luketomlinson
added a commit
that referenced
this pull request
Oct 20, 2021
Revert "Merge pull request #586 from C0ZEN/feature/split-pr-and-issue…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See the commits.
⚠️ please don't squash on merge, keep the commit like this; it will be way easier if there is a bug to debug and also to have a better changelog generated out of this!
Context
Remove the common options to favour using only PR and issues options.
This is reducing a lot the code base, the complexity, and the number of tests.
The documentation was also split to reflect this.
Closes #493