Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma in ::set-output` #208

Closed
hvr opened this issue Nov 8, 2019 · 3 comments · Fixed by #263
Closed

Trailing comma in ::set-output` #208

hvr opened this issue Nov 8, 2019 · 3 comments · Fixed by #263
Assignees
Labels
enhancement New feature or request

Comments

@hvr
Copy link

hvr commented Nov 8, 2019

I'm not sure if this is relevant, but I noticed that the log shows the meta-command

::set-output name=cache-hit,::true

being emitted, whereas based on Github actions documentation I would have expected

::set-output name=cache-hit::true

Sorry for the noise if this is in fact harmless.

@joshmgross
Copy link
Member

All "Commands" issued via the toolkit have this issue, from how they append properties: https://github.com/actions/toolkit/blob/master/packages/core/src/command.ts#L60

Both work, but it does look odd.

Going to transfer this issue to https://github.com/actions/toolkit

@joshmgross joshmgross transferred this issue from actions/cache Nov 8, 2019
@joshmgross joshmgross added the bug Something isn't working label Nov 8, 2019
@bryanmacfarlane
Copy link
Member

Yeah, this is as designed as the , is just an empty property. Both work.

@bryanmacfarlane bryanmacfarlane added question Further information is requested and removed bug Something isn't working labels Nov 11, 2019
@ericsciple
Copy link
Contributor

the trailing comma is kind of silly, we should probably remove it

@ericsciple ericsciple self-assigned this Nov 12, 2019
@ericsciple ericsciple added enhancement New feature or request and removed question Further information is requested labels Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants