Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing comma from commands #263

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Conversation

ericsciple
Copy link
Contributor

fixes #208

import * as command from '../src/command'
import * as os from 'os'

/* eslint-disable @typescript-eslint/unbound-method */
Copy link
Contributor Author

@ericsciple ericsciple Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so beforeAll can reference originalWriteFunction. note, core.test.ts does a similar thing so there was a precedent for disabling this already

@ericsciple ericsciple merged commit 568f12c into master Dec 18, 2019
@ericsciple ericsciple deleted the users/ericsciple/m163comma branch December 18, 2019 18:23
@@ -37,21 +37,21 @@ describe('@actions/core', () => {

it('exportVariable produces the correct command and sets the env', () => {
core.exportVariable('my var', 'var val')
assertWriteCalls([`::set-env name=my var,::var val${os.EOL}`])
assertWriteCalls([`::set-env name=my var::var val${os.EOL}`])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I missed it but do we have any tests that validate multiple properties (and thus does write the comma)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep command.test.ts is new and tests several combinations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing comma in ::set-output`
3 participants