-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @actions/http-client into the toolkit #1062
Conversation
ec32a39
to
fc57cec
Compare
fix failing http-client tests npm run lint-fix Simple manual fixes for lint rules Silence some linter errors Silence some linter warnings, but not "explicit any" Silence @typescript-eslint/no-explicit-any fix @typescript-eslint/no-non-null-assertion fix npm audit for http-client don't use I- prefix on interface names Get rid of `any` type in `Headers` Add http-client to the main README Update release notes
ff7f186
to
f300e2c
Compare
@@ -9,5 +9,5 @@ if [[ -z "$name" ]]; then | |||
exit 1 | |||
fi | |||
|
|||
lerna create @actions/$name | |||
cp packages/toolkit/tsconfig.json packages/$name/tsconfig.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We moved `@actions/http-client` to be part of the toolkit in #1062. We also made some breaking changes to exported types and released v2. The biggest change in terms of lines of code affected was to get rid of the `I-` prefix for interfaces since TypeScript doesn't follow this convention. I bumped the patch version of all packages except for `tool-cache`, where I bumped the major version. The rationale is explained in the release notes for that package.
@thboop @brcrista seems like moving Apparently this should be fixed in #1084 |
Thanks @karlhorky, should be fixed now #1085 |
We moved `@actions/http-client` to be part of the toolkit in actions/toolkit#1062. We also made some breaking changes to exported types and released v2. The biggest change in terms of lines of code affected was to get rid of the `I-` prefix for interfaces since TypeScript doesn't follow this convention. I bumped the patch version of all packages except for `tool-cache`, where I bumped the major version. The rationale is explained in the release notes for that package.
We moved `@actions/http-client` to be part of the toolkit in actions#1062. We also made some breaking changes to exported types and released v2. The biggest change in terms of lines of code affected was to get rid of the `I-` prefix for interfaces since TypeScript doesn't follow this convention. I bumped the patch version of all packages except for `tool-cache`, where I bumped the major version. The rationale is explained in the release notes for that package.
💡 See #1064 for a better diff!
https://github.com/actions/toolkit contains a variety of packages used for building actions. https://github.com/actions/http-client is one such package, but lives outside of the toolkit. Moving it inside of the toolkit will improve discoverability and reduce the number of repos we have to keep track of for maintenance tasks (such as github/c2c-actions-service#2937).
I checked with @bryanmacfarlane on the historical decision here. Apparently it was just inertia from before we released the toolkit as multiple packages.
The benefits here are:
Notes
@actions/http-client
will continue to be released as its own package.http-client
is currently breaking the safety of null-safe consumers.http-client
v2 to NPM until that's done just in case other changes shake out of it.