-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add helpers for working with paths across OSes #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great!
Could you go ahead and document these new functions in the README
for @actions/core
: https://github.com/actions/toolkit/tree/main/packages/core
@konradpabjan done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I'll differ for the final approval from @thboop before merging in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the contribution!
I was wondering what the purpose of these functions was compared to those from the native Path module (link). I figured it was discussed offline since it wasn't in the PR description. I'd love to understand so I can have a better idea of when they're recommended. Thanks! |
Hi @RA80533 these functions are for converting from platform-specific or non-platform-specific paths, regardless of the underlying operating system. |
No description provided.