Replace unzipper with unzip-stream #1601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtamsut
changed the title
unzipper with unzip-streamunzipper with unzip-stream
jtamsut
changed the title
unzipper with unzip-stream
robherley
reviewed
Dec 11, 2023
| @@ -9,6 +9,7 @@ | |||
| "@types/jest": "^29.5.4", | |||
| "@types/node": "^20.5.7", | |||
| "@types/signale": "^1.4.1", | |||
| "@types/unzip-stream": "^0.3.4", | |||
There was a problem hiding this comment.
this shouldn't be installed here, it should be within packages/artifact
robherley
reviewed
Dec 11, 2023
There was a problem hiding this comment.
FYI the unzip-stream package doesn't have the #promise method so we'll need something like this at the end of streamExtract:
return new Promise((resolve, reject) => {
response.message
.pipe(unzip.Extract({path: directory}))
.on('close', resolve)
.on('error', reject)
})
|
Closed in favor of: #1602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the
unzipperlibrary that causes files to become corrupted when streamed. This stems from changes from Node's handling of streams. We are replacingunzipperwithunzip-streamto as its a drop-in replacement with an identical API that doesn't suffer from the same issue.Closes https://github.com/github/actions-results-team/issues/2096