-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use import {Octokit} #332
Use import {Octokit} #332
Conversation
This change was made i n v16.43.1 but the version in package.json is v16.15.0 which is why all the builds failed. |
@xt0rted Thanks! Umm... Interesting... Actually, my project using |
I found the reason.
https://github.com/octokit/rest.js/releases/tag/v16.43.1 |
If you want to build with tsc now, add tsconfig.json
|
@technote-space Thank you very much for your useful tip: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will definitely fix the problem I mentioned in my comment. Thanks for opening!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump! Can we get this in soon please!
This resolves #333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Hi,
The purpose of this PR is to remove the following error.