Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more lenient in accepting command inputs #405

Merged
merged 7 commits into from
Apr 9, 2020

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Apr 6, 2020

Users have been encountering friction when trying to use command inputs.

This commit broke some our handling when users don't pass in strings. We re-added that handling and implemented a test for it.

We also have had a number of users ask for additional input types.
#386 -> Set Failed and Error should accept errors
#370 -> Set Output should format data into strings

This commit resolves those use cases.

Resolves #398, #386, #370

packages/core/src/core.ts Outdated Show resolved Hide resolved
@bryanmacfarlane
Copy link
Member

interested in @ericsciple feedback

@thboop thboop force-pushed the thboop/AddErrorInputToSetFailed branch from 508796f to 3ab3ad1 Compare April 9, 2020 14:45
@jasonkarns
Copy link

Late to the party here ( 🎉 for resolving!!)... but shouldn't the Error stringification use e.message instead of e.toString()? The toString method prepends "Error: ", to the message which is likely redundant and not desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: (s || "").replace is not a function
5 participants