-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add License.md to all npm packages #548
Conversation
@@ -0,0 +1,7 @@ | |||
Copyright 2019 GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a line with The MIT License (MIT)
at the top of each file?
Our licenses for some other repos have it included: https://github.com/actions/download-artifact/blob/c3f5d00c8784369c43779f3d2611769594a61f7a/LICENSE#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the correct license text, it is taken from the root license file in this repo.
example license: https://opensource.org/licenses/MIT
There's no harm in adding that extra line, but I don't see a reason to. I'll go ahead and make this update
* Add License.md to all npm packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve change reviews
Resolves #546