-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full release of actions/core 1.6.0 with oidc behavior #919
Conversation
…toolkit into main-oidc-client
Added OIDC client functionality in core package
react to OIDC service change.
packages/core/RELEASES.md
Outdated
@@ -1,5 +1,8 @@ | |||
# @actions/core Releases | |||
|
|||
### 1.6.0 | |||
- [Added OIDC Client function `getIDToken`](https://github.com/actions/toolkit/pull/887) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to update the link
packages/core/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@actions/core", | |||
"version": "1.5.0", | |||
"version": "1.6.0-beta.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the version.
return 'https://vstoken.actions.githubusercontent.com/.well-known/openid-configuration' | ||
} | ||
|
||
describe('oidc-client-tests', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we could have some real tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
private static getRequestToken(): string { | ||
const token = process.env['ACTIONS_ID_TOKEN_REQUEST_TOKEN'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using ACTIONS_ID_TOKEN_REQUEST_TOKEN
is inconsistent with the document where it suggests using ACTIONS_RUNTIME_TOKEN
:
jobs:
job:
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
id: script
timeout-minutes: 10
with:
debug: true
script: |
const token = process.env['ACTIONS_RUNTIME_TOKEN']
const runtimeUrl = process.env['ACTIONS_ID_TOKEN_REQUEST_URL']
core.setOutput('TOKEN', token.trim())
core.setOutput('IDTOKENURL', runtimeUrl.trim())
Also see github/docs#32573
No description provided.