Check for newlines and carriage return in artifact paths and name #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradpabjan
commented
Dec 1, 2021
Comment on lines
+56
to
+58
| 'some/invalid\rartifact/path', | ||
| 'some/invalid\nartifact/path', | ||
| 'some/invalid\r\nartifact/path', |
There was a problem hiding this comment.
New tests are here, I just moved everything into a separate file for better organization
robherley
approved these changes
Dec 1, 2021
packages/artifact/src/internal/path-and-artifact-name-validation.ts
Outdated
Show resolved
Hide resolved
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
…tions#951) * Check for newlines and carriage return in artifact paths and name * Fix linting issue * Update comments * Add comment about spacing * Remove extra space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce checking for newline characters and carriage returns in the artifact name and file paths that are uploaded
Will close out: actions/upload-artifact#183
utils.ts)\\rand\\nFor invalid artifact name: https://github.com/konradpabjan/artifact-test/actions/runs/1527098177
For invalid path: https://github.com/konradpabjan/artifact-test/actions/runs/1527052660
