[feat req] support colon in file names #546
Labels
enhancement
New feature or request
Comments
|
Alternatively handle this functionality in download-artifact instead |
nirs
added a commit
to nirs/ramen
that referenced
this issue
Jul 24, 2024
If any build step fails, try to gather the environment and upload the gathered data as build artifacts. The gathered data will be kept for 15 days (instead of the default 90 days) to minimize storage usage. We manually tar the gathered data for 2 reasons: - Avoid github limitations with special characters (:) in file names - Get much better compression compared to zip (6m instead of 12m) GitHub supports only zip format when downloading artifacts. You will download a tar.gz file wrapped in a zip archive. On macOS this is extracted automatically in one step. On Linux you will have to extract twice and delete the .zip and .tar.gz files. [1] actions/upload-artifact#546 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
ShyamsundarR
pushed a commit
to RamenDR/ramen
that referenced
this issue
Jul 24, 2024
If any build step fails, try to gather the environment and upload the gathered data as build artifacts. The gathered data will be kept for 15 days (instead of the default 90 days) to minimize storage usage. We manually tar the gathered data for 2 reasons: - Avoid github limitations with special characters (:) in file names - Get much better compression compared to zip (6m instead of 12m) GitHub supports only zip format when downloading artifacts. You will download a tar.gz file wrapped in a zip archive. On macOS this is extracted automatically in one step. On Linux you will have to extract twice and delete the .zip and .tar.gz files. [1] actions/upload-artifact#546 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added?
The current implementation halts with an error if the file names contains a colon. I suggest to introduce a parameter to allow this. For example
lowest_common_denomitator_filenames_enforced.Why is this needed?
upload-artifact fails if your artifact happens to include file names with a colon, which is a perfectly valid file name character on most OS's.
The text was updated successfully, but these errors were encountered: