Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: JSON mode configuration takes effect #2403

Merged
merged 2 commits into from
Jan 11, 2021
Merged

feat: JSON mode configuration takes effect #2403

merged 2 commits into from
Jan 11, 2021

Conversation

LUAgam
Copy link
Member

@LUAgam LUAgam commented Jan 7, 2021

Reason:
  Improve #2386 inner-453/658/507
Type:
  Improve
Influences：
Cluster subscriber update configuration
insert, delete and update of dble_information (single machine, cluster)

@LUAgam
fix: merge commit
7a2b6cd 
feat: JSON mode configuration takes effect
#2386

feat: table dble_config to view the json configuration in memory

inner-453

fix: json to map add unit test/update copyright

fix: 1 for Dereferenced variable may be null

fix: Dereferenced variable may be null
@github-actions github-actions bot requested a review from PanternBao January 7, 2021 06:47
@PanternBao PanternBao marked this pull request as draft January 8, 2021 09:32
@PanternBao
Copy link
Member

PanternBao commented Jan 8, 2021 •
edited
Loading

  1. High availability switch of dbInstance needs to be considered, so mark it draft.
  2. manager table and cluster concurrently modify config

@LUAgam LUAgam marked this pull request as ready for review January 11, 2021 03:35
PanternBao
PanternBao approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@PanternBao PanternBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PanternBao PanternBao self-requested a review January 11, 2021 10:16
@yanhuqing666 yanhuqing666 merged commit ddd0f19 into master Jan 11, 2021
@yanhuqing666 yanhuqing666 deleted the feature/jsonConfig branch January 11, 2021 10:24
LUAgam added a commit that referenced this pull request May 11, 2021
@LUAgam
feat: JSON mode configuration takes effect (#2403)
8bfb00e 
* fix: merge commit

feat: JSON mode configuration takes effect
#2386

feat: table dble_config to view the json configuration in memory

inner-453

fix: json to map add unit test/update copyright

fix: 1 for Dereferenced variable may be null

fix: Dereferenced variable may be null

* fix: dble_information adds distributed locks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PanternBao PanternBao PanternBao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LUAgam @PanternBao @yanhuqing666