Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inner-836:big packet support #2501

Merged
merged 1 commit into from
Mar 4, 2021
Merged

inner-836:big packet support #2501

merged 1 commit into from
Mar 4, 2021

Conversation

dcy10000
Copy link
Member

Signed-off-by: dcy dcy10000@gmail.com

Reason:
  BUG inner-836
Type:
  BUG
Influences:
   fix xx

@github-actions github-actions bot requested a review from ylinzhu February 26, 2021 04:08
Signed-off-by: dcy <dcy10000@gmail.com>
@github-actions github-actions bot requested a review from LUAgam March 4, 2021 05:16
@dcy10000 dcy10000 removed the request for review from LUAgam March 4, 2021 05:16
@ylinzhu
Copy link
Member

ylinzhu commented Mar 4, 2021

src/main/java/com/actiontech/dble/net/mysql/CommandPacket.java
BufferUtil.writeUB3(buffer, MySQLPacket.MAX_PACKET_SIZE);
buffer.put(packetId++);
remain = writeBody(buffer, isFirst, remain);
service.getSession().getShardingService().nextPacketId();
//service.getSession().getShardingService().nextPacketId();
service.writeDirectly(buffer);
isFirst = false;

remove useless code instead of comments

@dcy10000
Copy link
Member Author

dcy10000 commented Mar 4, 2021

src/main/java/com/actiontech/dble/net/mysql/CommandPacket.java
BufferUtil.writeUB3(buffer, MySQLPacket.MAX_PACKET_SIZE);
buffer.put(packetId++);
remain = writeBody(buffer, isFirst, remain);
service.getSession().getShardingService().nextPacketId();
//service.getSession().getShardingService().nextPacketId();
service.writeDirectly(buffer);
isFirst = false;

remove useless code instead of comments

done

Copy link
Member

@ylinzhu ylinzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@yanhuqing666 yanhuqing666 merged commit a5d5323 into master Mar 4, 2021
@yanhuqing666 yanhuqing666 deleted the inner-836-new2 branch March 4, 2021 08:10
LUAgam pushed a commit that referenced this pull request May 11, 2021
Signed-off-by: dcy <dcy10000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants