Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: modify table row key and remove redundant components #393

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

LZS911
Copy link
Collaborator

@LZS911 LZS911 commented Aug 20, 2024

actiontech/sqle#2523

修复:actiontech/sqle#2523 (comment)

问题原因:由于最初该表格数据没有返回 id,使用了 sql 作为表格主键,导致表格数据异常。

变更:

  • 调整表格row key
  • 删除冗余的组件

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.13% 12704/13216
🟡 Branches 79.76% 4970/6231
🟢 Functions 96.22% 4710/4895
🟢 Lines 96.67% 12468/12897

Test suite run success

2168 tests passing in 606 suites.

Report generated by 🧪jest coverage report action from fbfd65e

@LZS911
Copy link
Collaborator Author

LZS911 commented Aug 20, 2024

测试下评论,这个 pr 可以合并了

@LZS911
Copy link
Collaborator Author

LZS911 commented Aug 20, 2024

评论测试

@LZS911 LZS911 mentioned this pull request Aug 20, 2024
@anny1021 anny1021 merged commit 35289a5 into main Aug 22, 2024
9 checks passed
@anny1021 anny1021 deleted the fix/sqle-issue-2523 branch August 22, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants