Fix disabling of filters in latest active_admin #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If activeadmin/activeadmin#1454 is fixed, then we won't need to define |
elia
added a commit
that referenced
this pull request
Jul 5, 2012
Fix disabling of filters in latest active_admin
fred
pushed a commit
to fred/activeadmin-mongoid
that referenced
this pull request
Jul 30, 2013
Fix disabling of filters in latest active_admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest active_admin, this code expects
@searchto be set. This gem doesn't set it (because of its monkey patch to thesearchmethod), and AA fails with the following as a result:The reason is that the way in which this gem disables the sidebar no longer works. This patch uses a better way of disabling the sidebar (filters), so that the above error doesn't occur.