Add webpacker compatibility with config switch and installation generator #5855

sgara · 2019-09-13T13:15:20Z

After reading a few issues and related discussions (see #5829, #5551 and #5048), and willing to switch to webpacker myself, I wanted to propose a first step toward moving to webpacker. This is of course open to discussion. The goal here is to be able to simple switch to loading active_admin assets from webpack instead of sprockets. Also introduced a gemfile to generate development app running webpacker although there is no js nor css at the moment.

To me, the next step would be to create a npm package from sources present in this repo already. Note that a few changes may be required, I'm not sure we can have one set of assets compatible with both webpack and sprockets. But that can be discussed separately I guess

marcelotoledo5000

Congrats!

deivid-rodriguez · 2019-09-19T09:38:03Z

Thanks @sgara! I haven't missed this, I'll have a closer look soon but it looks like a good first initial step in principle!

sgara · 2019-09-19T12:27:20Z

thanks @deivid-rodriguez, no hurry. I'm already taking a look at the next step.
Moving assets to app/javascript, bundling with rollup for still being able to import through sprocket without breaking existing apps and keeping only one set of source files seems to be the way to go. We'll check that in another PR ;)

deivid-rodriguez

Starting to look into this. I added a few comments!

lib/active_admin/namespace_settings.rb

gemfiles/rails_60_webpacker.gemfile

spec/support/rails_template.rb

sgara · 2019-11-13T18:14:31Z

Finally getting there!
@deivid-rodriguez @javierjulio PR updated. I added generators and templates to have a seamless testing process, installation instructions, ...
Looking forward to have your comments!

nyrf · 2019-11-20T08:38:09Z

@sgara I got an error

undefined method `html_safe' for nil:NilClass
Did you mean?  html_safe?

sgara · 2019-11-20T08:50:44Z

Thanks for the feedback @nyrf I’ll look into it 👍

nyrf · 2019-11-21T03:25:32Z

@sgara I think that because of style file wouldn't be generated in development environment, so the style file seems like http://localhost:3000/7de125c1-80c7-4e9c-a40a-4a5547107245, i use stylesheet_pack_tag(style, options) || "" and then it works for me.

active_admin_application.stylesheets.each do |style, options|
  stylesheet_tag = active_admin_namespace.use_webpacker ? stylesheet_pack_tag(style, options) || "" : stylesheet_link_tag(style, options)
  text_node(stylesheet_tag.html_safe)
end

sgara · 2019-11-24T08:53:59Z

@nyrf should be fixed now, thanks for testing 👍

nyrf · 2019-11-27T00:45:17Z

@sgara It works. thanks for your work.

javierjulio

Looks great thanks! Just a suggestion on automating the webpacker environment config too.

docs/0-installation.md

maokomioko · 2019-12-04T10:22:13Z

Any chances we can merge it before 2.6 release? =^..^=

sgara · 2020-03-13T11:13:54Z

I have to go back into it, it's been such a while now I forgot most of it.
I've rebased the branch and added circleci jobs (nice catch 😆 ), I'll check on your comments

deivid-rodriguez

@sgara Added a final pass of comments. At this point really minor, I'm almost ready to merge and ship this! 🎉

gemfiles/rails_60_webpacker/Gemfile.lock

gemfiles/rails_60_webpacker/Gemfile

spec/support/rails_template.rb

spec/unit/views/pages/layout_spec.rb

deivid-rodriguez

It looks good to me! Just last tiny comments about the new Gemfile:

Can you run BUNDLE_GEMFILE=gemfiles/rails_60_webpacker/Gemfile bundle lock --add-platform java and commit the result? This makes it so that jruby developers don't get warnings when bundling the Gemfile. It will be done by default by the next bundler version, but it's not yet released.
Can you pin the rails dependency like it's done in master for the other Gemfiles? This is so that we still get the warnings fixed, but dependabot doesn't create PRs for every commit in Rails.

Other than these minor things, this looks good!

@javierjulio Any comments from your side? Does this look good to you?

sgara · 2020-03-17T14:46:07Z

I’ll make the changes tonight I think. Glad to see the end of the road!

javierjulio

Thank you @sgara for all your work here! It looks great. ❤️ All I have are minor comments. Majority are just text changes. Thanks David!

docs/0-installation.md

lib/generators/active_admin/install/install_generator.rb

lib/generators/active_admin/install/templates/active_admin.rb.erb

spec/requests/stylesheets_spec.rb

spec/support/rails_template.rb

CHANGELOG.md

lib/generators/active_admin/webpacker/templates/active_admin.js

Fix linting issue

Update webpacker Gemfile.lock Update Gemfile.lock Update webpacker gemfile to silence ruby 2.7 warnings Lock jruby dependencies Lock rails version Update Gemfile.lock

Use `generate` instead of `rake` for asset setup Clean duplicated comments Fix installation generator typo

Skip asset generation in case of conflicts Update rails_template.rb Put back turbolinks setup to previous rails template location

Update installation instructions Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net>

Remove circleci/config.yml trailing whitespace

Update rails_template.rb

Co-Authored-By: Javier Julio <javierjulio@icloud.com>

sgara · 2020-03-17T22:35:01Z

Applied changes from both @deivid-rodriguez and @javierjulio reviews and cleaned git history a bit.

deivid-rodriguez

Wowowowowoooo 🎉, this is so awesome and sooooo long due, THANK YOU!!!

The changes in the changelog collide with #6133, but I don't mind rebasing my changes after this one, so... 👍 from me!

javierjulio

Massive effort. Thanks so much @sgara for seeing this through! 👌🏻 We really appreciate it. ❤️

deivid-rodriguez · 2020-03-20T12:27:44Z

Great, I'll be releasing a new version very soon, thanks everyone, specifically @sgara for his massive effort!

ziaulrehman40 · 2021-03-22T09:43:24Z

Why did we not let users use both webpacker and sprockets at the same time?
It is very possible and used widely as well for some use cases.

If i make a PR to fix this, would that be accepted?

javierjulio · 2023-03-12T21:38:33Z

@ziaulrehman40 yes, I'd be interested to see what's involved.

marcelotoledo5000 previously approved these changes Sep 17, 2019

View reviewed changes

sgara mentioned this pull request Sep 20, 2019

Prepare js and css assets to work with both webpacker and sprocket #5865

Closed

deivid-rodriguez reviewed Sep 26, 2019

View reviewed changes

lib/active_admin/namespace_settings.rb Show resolved Hide resolved

gemfiles/rails_60_webpacker.gemfile Outdated Show resolved Hide resolved

spec/support/rails_template.rb Outdated Show resolved Hide resolved

sgara dismissed marcelotoledo5000’s stale review via 2c6d98a September 26, 2019 13:32

deivid-rodriguez mentioned this pull request Oct 2, 2019

Configure rollup to bundle javascript outside of sprockets #5868

Merged

sgara mentioned this pull request Oct 23, 2019

Publish @activeadmin/activeadmin package to npm #5894

Merged

sgara force-pushed the add-webpacker-switch branch from 90b7f19 to ad6f302 Compare October 23, 2019 12:56

sgara force-pushed the add-webpacker-switch branch from ad6f302 to 9f37c55 Compare November 13, 2019 17:28

javierjulio reviewed Nov 27, 2019

View reviewed changes

docs/0-installation.md Outdated Show resolved Hide resolved

sgara changed the title ~~Add simple config flag to switch to webpacker assets~~ Add webpacker compatibility with config switch and installation generator Dec 17, 2019

sgara force-pushed the add-webpacker-switch branch 5 times, most recently from 2aed4c4 to 74b3a7d Compare December 17, 2019 20:45

sgara requested review from javierjulio and deivid-rodriguez December 17, 2019 21:01

dzirtusss mentioned this pull request Dec 26, 2019

Feature request - webpacker ankane/blazer#243

Closed

sgara force-pushed the add-webpacker-switch branch 3 times, most recently from 85e86fc to a1350c0 Compare January 28, 2020 12:31

deivid-rodriguez reviewed Mar 15, 2020

View reviewed changes

deivid-rodriguez approved these changes Mar 17, 2020

View reviewed changes

javierjulio reviewed Mar 17, 2020

View reviewed changes

Update CHANGELOG.md

cacc343

Fix linting issue

sgara force-pushed the add-webpacker-switch branch 2 times, most recently from 3b8494e to 9355880 Compare March 17, 2020 21:29

sgara added 2 commits March 17, 2020 22:34

Add simple config flag to switch to webpacker assets

d6f240a

Update webpacker Gemfile.lock Update Gemfile.lock Update webpacker gemfile to silence ruby 2.7 warnings Lock jruby dependencies Lock rails version Update Gemfile.lock

Add generator and templates for webpacker configured app

b9e2fac

Use `generate` instead of `rake` for asset setup Clean duplicated comments Fix installation generator typo

sgara force-pushed the add-webpacker-switch branch 2 times, most recently from bf1c2c4 to c7729ae Compare March 17, 2020 22:05

sgara and others added 5 commits March 17, 2020 23:06

Automate jquery env setup

04f68fe

Skip asset generation in case of conflicts Update rails_template.rb Put back turbolinks setup to previous rails template location

Add installation instructions

bbc629e

Update installation instructions Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net>

Run webpacker tests in circleci

c30e2a5

Remove circleci/config.yml trailing whitespace

Update tests to work with both Sprockets and Webpacker apps

0781414

Update rails_template.rb

Apply suggestions from code review

8c5ed9d

Co-Authored-By: Javier Julio <javierjulio@icloud.com>

sgara force-pushed the add-webpacker-switch branch from c7729ae to 8c5ed9d Compare March 17, 2020 22:06

deivid-rodriguez approved these changes Mar 18, 2020

View reviewed changes

javierjulio approved these changes Mar 19, 2020

View reviewed changes

javierjulio merged commit 733a0d0 into activeadmin:master Mar 19, 2020

deivid-rodriguez mentioned this pull request Mar 20, 2020

Ensure changelog has well-defined main sections #6133

Merged

gsar mentioned this pull request Apr 16, 2020

fails to load with activeadmin with use_webpacker = true ankane/chartkick#531

Closed

This was referenced Apr 20, 2020

Rails 5.2 usage with webpack, without sprockets or coffeescript #5551

Closed

Should the sprockets dependency be removed? #6201

Closed

filipkis mentioned this pull request May 1, 2020

Remove sprockets based javascript dependency (Rails) ankane/pghero#215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add webpacker compatibility with config switch and installation generator #5855

Add webpacker compatibility with config switch and installation generator #5855

sgara commented Sep 13, 2019

marcelotoledo5000 left a comment

deivid-rodriguez commented Sep 19, 2019

sgara commented Sep 19, 2019

deivid-rodriguez left a comment

sgara commented Nov 13, 2019

nyrf commented Nov 20, 2019 •

edited

Loading

sgara commented Nov 20, 2019

nyrf commented Nov 21, 2019 •

edited

Loading

sgara commented Nov 24, 2019

nyrf commented Nov 27, 2019

javierjulio left a comment

maokomioko commented Dec 4, 2019

sgara commented Mar 13, 2020

deivid-rodriguez left a comment

deivid-rodriguez left a comment

sgara commented Mar 17, 2020

javierjulio left a comment

sgara commented Mar 17, 2020 •

edited

Loading

deivid-rodriguez left a comment

javierjulio left a comment

deivid-rodriguez commented Mar 20, 2020

ziaulrehman40 commented Mar 22, 2021

javierjulio commented Mar 12, 2023

Add webpacker compatibility with config switch and installation generator #5855

Add webpacker compatibility with config switch and installation generator #5855

Conversation

sgara commented Sep 13, 2019

marcelotoledo5000 left a comment

Choose a reason for hiding this comment

deivid-rodriguez commented Sep 19, 2019

sgara commented Sep 19, 2019

deivid-rodriguez left a comment

Choose a reason for hiding this comment

sgara commented Nov 13, 2019

nyrf commented Nov 20, 2019 • edited Loading

sgara commented Nov 20, 2019

nyrf commented Nov 21, 2019 • edited Loading

sgara commented Nov 24, 2019

nyrf commented Nov 27, 2019

javierjulio left a comment

Choose a reason for hiding this comment

maokomioko commented Dec 4, 2019

sgara commented Mar 13, 2020

deivid-rodriguez left a comment

Choose a reason for hiding this comment

deivid-rodriguez left a comment

Choose a reason for hiding this comment

sgara commented Mar 17, 2020

javierjulio left a comment

Choose a reason for hiding this comment

sgara commented Mar 17, 2020 • edited Loading

deivid-rodriguez left a comment

Choose a reason for hiding this comment

javierjulio left a comment

Choose a reason for hiding this comment

deivid-rodriguez commented Mar 20, 2020

ziaulrehman40 commented Mar 22, 2021

javierjulio commented Mar 12, 2023

nyrf commented Nov 20, 2019 •

edited

Loading

nyrf commented Nov 21, 2019 •

edited

Loading

sgara commented Mar 17, 2020 •

edited

Loading