Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert public token handling until future release #2755

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

nvoxland-al
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Revert unreleased changes

Description

With updates to the auth work, I added an optimization for public token handling which will not work with the current production hub server code.

This PR reverts the code back to what was in main on the last release

Things to be aware of

We can bring this change back after teh server-side changes have been made

@nvoxland-al nvoxland-al requested a review from fayaz-al January 30, 2024 17:32
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8693b18) 83.79% compared to head (38beab1) 83.81%.
Report is 9 commits behind head on main.

❗ Current head 38beab1 differs from pull request most recent head 9eedfd7. Consider uploading reports for the commit 9eedfd7 to get more accurate results

Files Patch % Lines
deeplake/client/client.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2755      +/-   ##
==========================================
+ Coverage   83.79%   83.81%   +0.02%     
==========================================
  Files         233      233              
  Lines       26461    26466       +5     
==========================================
+ Hits        22172    22183      +11     
+ Misses       4289     4283       -6     
Flag Coverage Δ
unittests 83.81% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nvoxland-al nvoxland-al merged commit 85c5185 into main Feb 1, 2024
10 checks passed
@nvoxland-al nvoxland-al deleted the revert_public_token_handling branch February 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants