Cyber source rest store unstore #4709
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CybersourceRest: adding gateway Summary: ------------------------------ Adding CybersourceRest gateway with authorize and purchase calls. GWI-474 Remote Test: ------------------------------ Finished in 3.6855 seconds. 6 tests, 17 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 35.528692 seconds. 5441 tests, 77085 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 760 files inspected, no offenses detected
…hant/active_merchant into CyberSourceREST_store_unstore
Sainterman
requested review from
Heavyblade,
edgarv09,
jherreraa,
sinourain and
gasb150
sinourain
reviewed
Feb 27, 2023
| post[:buyerInformation][:merchantCustomerId] = options[:customer_id] | ||
| post[:buyerInformation][:email] = options[:email].presence || 'null@cybersource.com' | ||
| add_code(post, options) | ||
| post[:merchantDefinedInformation] = [] |
There was a problem hiding this comment.
Seems that this is twice (82 and 86 have the same merchantDefinedInformation definition)
sinourain
reviewed
Feb 27, 2023
| when /payments/ | ||
| response['status'] == 'AUTHORIZED' | ||
| else | ||
| !response['id'].nil? |
There was a problem hiding this comment.
why don't we use response['id'].present?
gasb150
reviewed
Mar 7, 2023
| else | ||
| return response['id'].present? unless http_method == :delete | ||
|
|
||
| return true |
There was a problem hiding this comment.
| def message_from(response) | ||
| return response['status'] if success_from(response) | ||
| def message_from(action, response, http_method) | ||
| return response['status'] if success_from(action, response, http_method) |
There was a problem hiding this comment.
Instead of recalling the succes_from method, it is possible to use the call in the commit method.
def commit
# commit code
succeeded = success_from(action, response, http_method)
Response.new(
succeeded,
message_from(response, succeeded)
# other response fields
error_code: error_code_from(response, succeeded)
)
# other commit code
end
def message_from(response, succeeded)
return response['status'] if succeeded
response['errorInformation']['message']
end
def error_code_from(response, succeeded)
response['errorInformation']['reason'] unless succeeded
end
|
Marking this "of interest" before a cleanup of stale PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CyberSourceREST: Add Store and Unstore methods
To store a payment method in CyberSource the Token management system(TMS) provides
the customer, InstrumentIdentifier and PaymentInstrument endpoints.
Sending a purchase request can be done with the customer_id returned by the customer endpoint once a paymentInstrument and an instrumentIdentifier are created.