Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cecabank: Add scrub implementation #4945

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

sinourain
Copy link
Contributor

Description

Add scrub logic to protect sensitive data from the credit card

For Spreedly reference:
SER-956

Unit test

Finished in 25.362182 seconds.
5664 tests, 78328 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote test

223.32 tests/s, 3088.38 assertions/s

Rubocop

Inspecting 778 files
778 files inspected, no offenses detected

@sinourain sinourain requested review from naashton and removed request for naashton November 4, 2023 01:11
Description
-------------------------

Add scrub logic to protect sensitive data from the credit card

For Spreedly reference:
SER-956

Unit test
-------------------------
Finished in 25.362182 seconds.
5664 tests, 78328 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote test
-------------------------
223.32 tests/s, 3088.38 assertions/s

Rubocop
-------------------------
Inspecting 778 files
778 files inspected, no offenses detected
@naashton naashton force-pushed the Cecabank_add_scrub_implementation branch from d25185e to 7b69a2d Compare November 6, 2023 15:10
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work! Great job, @sinourain!

@naashton naashton merged commit bcc5e16 into master Nov 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants