Fatzebra: fix directory_server_transaction_id mapping #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ------------------------------ Rename the equivalent ds_transaction_id in fatzebra for directory_server_txn_id, to map it corrctly. [ECS-3660](https://spreedly.atlassian.net/browse/ECS-3660) [UBI-132](https://spreedly.atlassian.net/browse/UBI-132) Remote Tests: ------------------------------ Finished in 87.765183 seconds. 30 tests, 104 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed *Note Failing Test*: We have to remote tests failing because seems to be a change on the sandbox behavior when a transaction doesn't include a cvv Unit Tests: ------------------------------ Finished in 0.073139 seconds. 23 tests, 130 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 798 files inspected, no offenses detected
sinourain
approved these changes
Jul 30, 2024
bryansquadup
pushed a commit
to givehub/active_merchant
that referenced
this pull request
Aug 21, 2024
…#5197) Summary: ------------------------------ Rename the equivalent ds_transaction_id in fatzebra for directory_server_txn_id, to map it corrctly. [ECS-3660](https://spreedly.atlassian.net/browse/ECS-3660) [UBI-132](https://spreedly.atlassian.net/browse/UBI-132) Remote Tests: ------------------------------ Finished in 87.765183 seconds. 30 tests, 104 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed *Note Failing Test*: We have to remote tests failing because seems to be a change on the sandbox behavior when a transaction doesn't include a cvv Unit Tests: ------------------------------ Finished in 0.073139 seconds. 23 tests, 130 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 798 files inspected, no offenses detected Co-authored-by: Gustavo Sanmartin <gsanmartin@en2010382.endava.net>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rename the equivalent ds_transaction_id in fatzebra for directory_server_txn_id, to map it corrctly.
ECS-3660
UBI-132
Remote Tests:
Finished in 87.765183 seconds.
30 tests, 104 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.3333% passed
Note Failing Test: We have to remote tests failing because seems to be a change on the sandbox behavior when a transaction doesn't include a cvv
Unit Tests:
Finished in 0.073139 seconds.
23 tests, 130 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
RuboCop:
798 files inspected, no offenses detected