Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.5 or older versions of Ruby #1189

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Drop Ruby 2.5 or older versions of Ruby #1189

merged 2 commits into from
Dec 30, 2020

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Dec 25, 2020

README already mentions that Ransack is supported for Rails 6.1, 6.0, 5.2 on Ruby 2.6.6 and later. by d508857

I'd like to get some feed back from maintainers since #1070 just dropped Ruby 2.2 or older versions of Ruby.

README already mentions that `Ransack is supported for Rails 6.1, 6.0,
5.2 on Ruby 2.6.6 and later.`
d508857
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with it, thanks!

I would add a changelog entry for it though.

@yahonda
Copy link
Contributor Author

yahonda commented Dec 30, 2020

Thanks for the review. Added a changelog entry.

@deivid-rodriguez
Copy link
Contributor

Thank you!

@deivid-rodriguez deivid-rodriguez merged commit 48b2e28 into activerecord-hackery:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants