Fix issue with ransackable_attribute not handling symbols correctly #1539
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1538
If the behavior is as intended, please close this PR.
Problem
When using the ransackable_attributes method in ActiveRecord, passing an array of symbols causes the search conditions for the corresponding attributes to be ignored. However, passing an array of strings works as expected.
Steps to Reproduce
1: Create a migration for a users table with a name column:
2: Define the User model with ransackable_attributes returning a symbol array:
3: Attempt to perform a Ransack query with a condition on the name attribute:
User.ransack(name_cont: "hoge").result.to_sql
Actual Behavior
The generated SQL query ignores the condition for name:
SELECT "users".* FROM "users"