Evaluate ransackable_scopes before attributes when building the query #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paragraph in README.md shows that Ransack can properly evaluate this scope:
if the scope is properly whitelisted:
However, it is not the case because
attribute_method?(salary_gt)
will evaluate totrue
even if the attribute is not whitelisted inransackable/ransortable_attributes
.I assumed that scopes were introduced to easily override/customize
#{attribute}_#{predicate}
pair without breaking the naming convention.In that case this PR should make ransack work as per the README mentioned above.
Test cases will follow, but I would appreciate initial Yes/No before putting more time in to it.