Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All refactored except issue with hosted_by #1045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akdave2003
Copy link

Contributor checklist


Description

Related issue

https://github.com//issues/968

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@andrewtavis andrewtavis self-requested a review December 8, 2024 16:04
Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit e5a4cc0
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67578fa58f455b0008a54869
😎 Deploy Preview https://deploy-preview-1045--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis
Copy link
Member

Hey @akdave2003 👋 Thanks so much for sending this along :) I think the header problems are from the addition of $t properties in the HTML strings. Maybe we can convert those over to computed variables and then we can have them in the strings with ${computedVariableName}? Happy to help with this!

@akdave2003
Copy link
Author

I made this change is this what you are referring to?
Screenshot 2024-12-08 at 8 52 40 PM

@andrewtavis
Copy link
Member

That looks like a step in the right direction :) Do you want to send it along?

@akdave2003
Copy link
Author

Changed and updated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants