-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(i18n): standardize localization key references across components #1118
refactor(i18n): standardize localization key references across components #1118
Conversation
…ents Issue: activist-org#1100 - Migrate all inline i18n keys to use i18nMap object for type-safe references - Add consistent 'i18n.' namespace prefix to translation keys in: - EmptyState component buttons - CardGetInvolvedOrganization links - CardSearchResult aria labels - MediaMap control tooltips - ModalEditFaqEntry text checks - Group/resource creation pages - Sidebar navigation labels - Update HTML title attributes to use translated strings via i18nMap - Import i18nMap in files where missing (MediaMap, groupSubPages) - Fix key consistency in discussion input component
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
@andrewtavis I didn't know how to fix this one from /frontend/components/combobox/ComboboxTopics.vue (lines 117-129): (if it even needed fixing)
|
I'll get the formatting check in the review here, @aasimsyed :) No stress 😊 |
frontend/components/EmptyState.vue
Outdated
@@ -61,37 +61,37 @@ | |||
v-if="pageType == 'organizations'" | |||
class="w-full" | |||
:cta="true" | |||
label="components.empty_state.create_organization" | |||
label="i18n.components.empty_state.create_organization" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of Vue learning here, @aasimsyed: What we do here is preppend label
with :
, which is short for v-bind:label
(see v-bind docs on W3 Schools). This allows us to pass a variable inside of a string. I'll fix these quickly 😊
And in the comment above, good catch! We should include that string in the i18n values :) I'll add that in as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, @aasimsyed! This is great 😊 I'm realizing that there are a few more that can be found in cases that are not the search methods that I defined in the issue, so let me detail those and then you can take those down as well :)
Wonderful to work with you again!
Issue: #1100
Contributor checklist
Description
Related issue