Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(settings): add TLS #380

Merged
merged 35 commits into from
Aug 3, 2024
Merged

feature(settings): add TLS #380

merged 35 commits into from
Aug 3, 2024

Conversation

0rangeFox
Copy link
Contributor

@0rangeFox 0rangeFox commented Jan 7, 2024 •
edited
Loading

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Added the logic to get the TLS option working, and separated this component as feature tls.

@robjtede robjtede added B-semver-minor A-settings Project: actix-settings labels Jan 22, 2024
@0rangeFox
Copy link
Contributor Author

The doc test workflow is prone to fail due to missing certificates on the TLS example.

@0rangeFox

This comment was marked as resolved.

Sign in to view
@robjtede

This comment was marked as resolved.

Sign in to view
jayvdb
jayvdb reviewed Feb 14, 2024
View reviewed changes
actix-settings/src/lib.rs Outdated Show resolved Hide resolved
@robjtede
Copy link
Member

Can the feature be renamed to openssl please so we can add rustls later.

robjtede
robjtede approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks 👍🏻

@robjtede robjtede enabled auto-merge August 3, 2024 08:53
@robjtede robjtede added this pull request to the merge queue Aug 3, 2024
Merged via the queue into actix:master with commit 31b1dc5 Aug 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

@jayvdb jayvdb jayvdb approved these changes

Assignees
No one assigned
Labels
A-settings Project: actix-settings B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0rangeFox @robjtede @jayvdb