Global request size limit?

[cupcakearmy]

Hi there,

I was trying to get a global size limit on requests. I tryed using the actix_web::web::PayloadConfig with STAR_STAR Mime, but it seems to have no effect.

With Struct actix_web::web::JsonConfig it seems to work, but only applies to json.

[aliemjay]

This should work! Can you state how this fails for you? What are your expectations?

[cupcakearmy]

main

use actix_web::{middleware, web, App, HttpServer};
use dotenv::dotenv;

#[macro_use]
extern crate lazy_static;

mod client;
mod note;
mod size;
mod store;

#[actix_web::main]
async fn main() -> std::io::Result<()> {
    dotenv().ok();
    return HttpServer::new(|| {
        App::new()
            .wrap(middleware::Compress::default())
            .wrap(middleware::DefaultHeaders::default())
            .configure(size::init)
            .configure(note::init)
            .configure(client::init)
            .default_service(web::resource("").route(web::get().to(client::fallback_fn)))
    })
    .bind("0.0.0.0:5000")?
    .run()
    .await;
}

The working json ist this

use actix_web::web;
use byte_unit::Byte;

lazy_static! {
  pub static ref LIMIT: usize =
    Byte::from_str(std::env::var("SIZE_LIMIT").unwrap_or("1 KiB".to_string()))
      .unwrap()
      .get_bytes() as usize;
}

pub fn init(cfg: &mut web::ServiceConfig) {
  let config = web::JsonConfig::default().limit(*LIMIT);
  cfg.data(config);
}

use actix_web::web;
use byte_unit::Byte;
use mime;

lazy_static! {
  pub static ref LIMIT: usize =
    Byte::from_str(std::env::var("SIZE_LIMIT").unwrap_or("1 KiB".to_string()))
      .unwrap()
      .get_bytes() as usize;
}

pub fn init(cfg: &mut web::ServiceConfig) {
  println!("Limit: {}", *LIMIT);
  let config = web::PayloadConfig::default()
    .limit(*LIMIT)
    .mimetype(mime::STAR_STAR);
  // let config = web::JsonConfig::default().limit(*LIMIT);
  cfg.data(config);
}

With the JSONConfig there is the 413 code returning on a too big request. with the default config it just goes thorugh.

[aliemjay]

PayloadConfig applies only to Bytes and String extractors. So unless you have theses extractors it has no effect.

[cupcakearmy]

Ah ok, I see now. Thanks!