-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip empty chucks for BodyStream and SizedStream #1308
Skip empty chucks for BodyStream and SizedStream #1308
Conversation
@JohnTitor I've implemented option 2 described here as the most preferred among commenters. But I'll change it if we should go with another one. |
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
- Coverage 79.43% 79.43% -0.01%
==========================================
Files 146 146
Lines 17004 17006 +2
==========================================
+ Hits 13507 13508 +1
- Misses 3497 3498 +1
Continue to review full report at Codecov.
|
Could you also update the changelog with the PR number? |
Thanks! |
Fixes #1267
This PR makes
BodyStream
andSizedStream
inactix-http
crate to skip empty chunks whicl streaming HTTP response, so omit unexpected termination.