-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change NormalizePath to append trailing slash #1433
Conversation
Can you add tests so we never see regressions. |
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
+ Coverage 47.91% 48.03% +0.12%
==========================================
Files 137 137
Lines 12805 12826 +21
==========================================
+ Hits 6135 6161 +26
+ Misses 6670 6665 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution
Can you update changelog also? |
done, merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
For paths like /blah/ requests like /////blah now work. Previously this would 404 as the trailing slash was missing and NormalizePath only replaces multiples and doesn't add the trailing slash when missing.