Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide impl<T> From<Arc<T>> for Data<T> #1509

Merged
merged 4 commits into from
May 15, 2020

Conversation

svenallers
Copy link
Contributor

Resolves #1300

@codecov-io
Copy link

Codecov Report

Merging #1509 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
+ Coverage   47.58%   47.61%   +0.02%     
==========================================
  Files         137      137              
  Lines       12925    12931       +6     
==========================================
+ Hits         6151     6157       +6     
  Misses       6774     6774              
Impacted Files Coverage Δ
src/data.rs 94.94% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ce975...3ee1fbf. Read the comment docs.

Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@robjtede
Copy link
Member

Can you add a CHANGELOG entry?

@robjtede robjtede merged commit 201090d into actix:master May 15, 2020
@svenallers svenallers deleted the 1300-data-from-arc branch May 16, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl From<Arc<T>> for web::Data<T>
4 participants