Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print unconfigured Data<T> type when attempting extraction #1743

Merged

Conversation

cquintana-verbio
Copy link
Contributor

@cquintana-verbio cquintana-verbio commented Oct 19, 2020

PR Type

Other

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

This PR aims to help developers when facing the

Failed to construct App-level Data extractor. Request path: "/your-endpoint"

Now, it will print something like the following:

Failed to construct App-level Data extractor. Request path: "/your-endpoint" (type = THE_TYPE_WILL_APPEAR_HERE)

@robjtede robjtede requested review from a team October 20, 2020 15:32
@robjtede robjtede added A-web project: actix-web B-semver-minor labels Oct 20, 2020
CHANGES.md Outdated Show resolved Hide resolved
@robjtede robjtede changed the title Print unconfigured AppData type Print unconfigured Data<T> type when attempting extraction Oct 20, 2020
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! I didnt know about that. This will be a significant improvement to DX.

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #1743 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1743   +/-   ##
=======================================
  Coverage   53.60%   53.60%           
=======================================
  Files         128      126    -2     
  Lines       11997    11996    -1     
=======================================
  Hits         6431     6431           
+ Misses       5566     5565    -1     
Impacted Files Coverage Δ
src/data.rs 93.51% <0.00%> (-0.88%) ⬇️
actix-http/src/header/common/last_modified.rs
actix-http/src/header/common/accept_language.rs
actix-http/src/header/common/accept_charset.rs
actix-http/src/header/common/content_language.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92742b...ec8e66e. Read the comment docs.

@robjtede robjtede merged commit 98243db into actix:master Oct 20, 2020
@robjtede robjtede mentioned this pull request Oct 20, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants