Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export bytes::Buf and bytes::BufMut as well #1750

Merged
merged 3 commits into from
Oct 24, 2020

Conversation

therealprof
Copy link
Contributor

@therealprof therealprof commented Oct 23, 2020

PR Type

Other

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

actix-web is re-exporting bytes::Bytes and bytes::BytesMut, however it does not re-export the traits bytes::Buf and bytes::BufMut which are required to actually do something with the types in applications which means that users of those types have to import the traits from bytes directly which (as it currently the case) can cause version clashes. By re-exporting the traits as well we can eliminate this stumbling block and simplify the use.

Signed-off-by: Daniel Egger daniel.egger@axiros.com

Signed-off-by: Daniel Egger <daniel.egger@axiros.com>
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #1750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1750   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files         127      127           
  Lines       12062    12062           
=======================================
  Hits         6487     6487           
  Misses       5575     5575           
Impacted Files Coverage Δ
src/web.rs 85.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45a1aa...f201294. Read the comment docs.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense for me, could you add an entry to the changelog?

@robjtede robjtede added A-web project: actix-web B-semver-patch labels Oct 24, 2020
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is more important now that bytes 0.6 is out.

@robjtede robjtede merged commit 41e7cec into actix:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants