-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove actix-threadpool.use actix_rt::task::spawn_blocking #1878
Conversation
Canceled, | ||
} | ||
|
||
impl<E: fmt::Debug> std::error::Error for BlockingError<E> {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derive_more Error would delcare E the source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from the actix-threadpool code and I believe it's explictly added by a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay can do it later if needed
I've migrate |
PR Type
Dependency
PR Checklist
Check your PR fulfills the following:
Overview
Remove
actix-threadpool
fromactix-http
andactix-web
.Use
actix_rt::task::spawn_blocking
as the new blocking thread pool.actix_threadpool::BlockingError
has been moved intoactix_http::error
module and can also be import fromactix_web::error
module.This is not a break change from
actix-web
andactix-http
as the public API and types related stays the same. It's only when factoring people may useactix-threadpool
together in their app and import types(BlockingError for example) from there and that would be breaking.