Fix Json extractor to be 32kB by default #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
added
A-web
robjtede
approved these changes
Feb 18, 2021
While technically the default limit for `JsonBody` is indeed 256kB when called through `JsonBody::new`, in practice the limit is always set to 32kB for every context where `JsonBody` is used (via `JsonConfig`). This is also consistent with the documentation of the `JsonError::Overflow`, which mentions a default maximum of `32kB`. This commit changes the default to also be `32kB` instead of `256kB`.
SuperFluffy
force-pushed
the
fix_json_default_limit
branch
from
6d26793 to
0501193
Compare
Done. |
robjtede
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Other
PR Checklist
Overview
While technically the default limit for
JsonBodyis indeed 256kB when called throughJsonBody::new, in practice the limit is always set to 32kB for every context whereJsonBodyis used (viaJsonConfig). This is also consistent with the documentation of theJsonError::Overflow, which mentions a default maximum of32kB.This commit changes the default to also be
32kBinstead of256kB.Alternatives
The alternative to this commit is to instead change the default of
JsonConfigto have a limit of256kBinstead of currently32kB.