Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger middleware properly escape %% #2067

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Fix logger middleware properly escape %% #2067

merged 2 commits into from
Mar 11, 2021

Conversation

a1ien
Copy link
Contributor

@a1ien a1ien commented Mar 11, 2021

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Closes #1997

@robjtede robjtede added A-web project: actix-web B-semver-patch labels Mar 11, 2021
robjtede
robjtede approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍🏻

@robjtede robjtede merged commit 22dcc31 into actix:master Mar 11, 2021
@a1ien a1ien deleted the fix_percent_logger_format branch March 11, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logger middleware format doesn't properly escape %%
2 participants
@a1ien @robjtede