remove json and url encoded form support from -http #2148
Conversation
robjtede
added
B-semver-major
| @@ -209,7 +209,8 @@ impl RequestSender { | |||
| ) -> SendClientRequest { | |||
| let body = match serde_json::to_string(value) { | |||
| Ok(body) => body, | |||
| Err(e) => return Error::from(e).into(), | |||
| // TODO: own error type | |||
| Err(e) => return Error::from(io::Error::new(io::ErrorKind::Other, e)).into(), | |||
There was a problem hiding this comment.
Thoughts on what do do here @fakeshadow, maybe a wrapped error that can also hold serialization errors as well as client errors from -http. Might leave it for a separate PR if you want to handle it.
|
Howdy! Bit of feedback on this, particularly the error changes, since it wasn't clear to me how to operate without those helpers. Up through beta.5, I was able to do things like |
PR Type
Dep Reduction
PR Checklist
Overview
Further reduce the number of dependencies on -http, making it simpler.
Removes some
Into<Error>andResponseErrorimpls for each lib's error types. I think this makes sense anyway but need to look at the error system before v4 anyhow, it's possible the response error trait can be moved to -web, too, which would make it possible to re-impl for these types.