-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uri typed headers #3455
Open
keithamus
wants to merge
10
commits into
actix:master
Choose a base branch
from
keithamus:add-uri-typed-headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add uri typed headers #3455
+130
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
add-uri-typed-headers
branch
2 times, most recently
from
August 17, 2024 22:33
c75c46d
to
3d17c3f
Compare
robjtede
requested changes
Aug 19, 2024
keithamus
force-pushed
the
add-uri-typed-headers
branch
from
August 19, 2024 13:13
3d17c3f
to
f96a21f
Compare
@robjtede those changes have been made. Let me know if you have any more feedback. |
I'm still interested in this patch, if you think it's worth merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
This adds the
Location
,Content-Location
andReferer
typed headers. It also adds theTryIntoHeaderValue
trait forUri
which allowsUri
to be a typed value for these headers.While
Location
technically is a different type thanContent-Location
andReferer
(Location
allows for protocol relative URIs) I think it's not a large enough distinction to warrant a separate type, as using protocol relative urls is quite rare. However we could useurl::Url
instead ofUri
forLocation
if we wanted to allow for that distinction.The motivation for this PR is to allow for using
Referer
as an Extractor, and the other two were easy enough to also add, and complete the trifecta of URI related headers (to the best of my knowledge).