-
Notifications
You must be signed in to change notification settings - Fork 173
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add useTime to AMVFinder + python binding (#2721)
Enables time seeding and time impact point estimation for `AMVF (+grid seeder) seeded`! For `AMVF (+grid seeder) ttbar` the performance is deteriorating because the parameters of `AdaptiveGridDensityVertexFinder` were tuned for `AMVF (+grid seeder) seeded`. The parameters for ttbar will be tuned once #2745 went in (at the moment, the grid seeder is templated to the grid size so we can't adapt these parameters at run time). In the following, we will discuss the physmon for `AMVF (+grid seeder) seeded`: We get some sensible pulls for the vertex time: ![image](https://github.com/acts-project/acts/assets/72298366/a04db989-f19a-432c-a923-32ee7af8159f) Also, the vertex time residual looks good: ![image](https://github.com/acts-project/acts/assets/72298366/153294d5-591e-4570-9b1f-c51b9b63b692) Using the additional coordinate we are able to resolve more vertices: ![image](https://github.com/acts-project/acts/assets/72298366/b5d7d6a6-4d42-4e45-bb98-019bfc68ac72) At the same time, we don't overshoot (i.e., reconstruct more vertices than there are) as this plot nicely shows. Finally, we are able to better resolve which track corresponds to which vertex: ![image](https://github.com/acts-project/acts/assets/72298366/580b46c4-ac34-4670-b9d6-0f7db3dcbb91) Some remarks: Even though we reconstruct more vertices, the number of entries in the histogram of the vertex covariance seems to decrease: ![image](https://github.com/acts-project/acts/assets/72298366/cc798708-bbf3-4f4c-b4a8-1acda0d03ae4) However, this is not actually the case: the tail of the monitored distribution just gets longer. For higher pile-ups, we expect the improvement to be even more significant.
- Loading branch information
1 parent
5cc42d2
commit 0d1e675
Showing
9 changed files
with
84 additions
and
29 deletions.
There are no files selected for viewing
Binary file modified
BIN
+1.03 KB
(100%)
CI/physmon/reference/performance_amvf_gridseeder_seeded_hist.root
Binary file not shown.
Binary file modified
BIN
-209 Bytes
(99%)
CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters