fix: Flag for secondary vertex labeling in Pythia8ProcessGenerator (#…

…2989) Currently we label secondary vertices in `Pythia8ProcessGenerator` that are for example products of prompt decays. I flag this labeling procedure and change the default to assign everything to the primary vertex.
acts-project · Feb 27, 2024 · 1cc1759 · 1cc1759
1 parent e06342c
commit 1cc1759
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 2 deletions.
diff --git a/CI/physmon/reference/performance_ambi_ttbar.root b/CI/physmon/reference/performance_ambi_ttbar.root
diff --git a/CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root b/CI/physmon/reference/performance_amvf_gridseeder_ttbar_hist.root
diff --git a/CI/physmon/reference/performance_amvf_ttbar_hist.root b/CI/physmon/reference/performance_amvf_ttbar_hist.root
diff --git a/CI/physmon/reference/performance_ckf_ttbar.root b/CI/physmon/reference/performance_ckf_ttbar.root
diff --git a/CI/physmon/reference/performance_seeding_ttbar.root b/CI/physmon/reference/performance_seeding_ttbar.root
diff --git a/CI/physmon/reference/tracksummary_ckf_ttbar_hist.root b/CI/physmon/reference/tracksummary_ckf_ttbar_hist.root
diff --git a/Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.cpp b/Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.cpp
@@ -107,7 +107,7 @@ ActsExamples::SimParticleContainer ActsExamples::Pythia8Generator::operator()(
     // ensure particle identifier component is non-zero
     particleId.setParticle(1u + generated.size());
     // only secondaries have a defined vertex position
-    if (genParticle.hasVertex()) {
+    if (m_cfg.labelSecondaries && genParticle.hasVertex()) {
       // either add to existing secondary vertex if exists or create new one
       // TODO can we do this w/o the manual search and position check?
       auto it = std::find_if(

diff --git a/Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.hpp b/Examples/Algorithms/GeneratorsPythia8/ActsExamples/Generators/Pythia8ProcessGenerator.hpp
@@ -40,6 +40,10 @@ class Pythia8Generator : public EventGenerator::ParticlesGenerator {
     bool printShortEventListing = false;
     /// Let pythia print detailed event info
     bool printLongEventListing = false;
+    /// Turn on/off the labeling of secondary vertices
+    /// TODO this is essentially broken as the current code will label any kind
+    /// of decay as secondary
+    bool labelSecondaries = false;
   };
 
   Pythia8Generator(const Config& cfg, Acts::Logging::Level lvl);

diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt
@@ -1,4 +1,4 @@
-test_pythia8__pythia8_particles.root: 082eb3dbf142929df28acfec48d61f260e132cb103966d143f430eeeda89daa1
+test_pythia8__pythia8_particles.root: 79fa44dadc3193c9349c108c7a784d6121d343f88e8059ca11eed442ab1d49db
 test_fatras__particles_simulation.root: 4ce0feb0ecb234143f418789a7a0d377f4a653d529c49bf999dda1878c50cee1
 test_fatras__hits.root: 2e47d9ba55fa1b377f70c361107fe811e9880d14c42cb3d7a9cd4616a6f33a54
 test_geant4__particles_simulation.root: 29fb3ed0c9ea48bc64cb6e4a83f4f6ca535415ab7a71051ca385943ce3dea31f