Skip to content

Commit

Permalink
ci: Physmon comment report pipes through summary (#2342)
Browse files Browse the repository at this point in the history
This PR changes the physmon report CI job to basically pipe through the `summary.md` that we create inside the physmon job to the comment. This should be more robust than what we had before.

Blocked by
- #2339
  • Loading branch information
paulgessinger authored Aug 4, 2023
1 parent b5acca1 commit 3f4cbab
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 269 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,14 @@ jobs:
- name: Render comment
if: steps.get-pr-number.outputs.result != 'false'
run: |
pip install Jinja2
ls -al $GITHUB_WORKSPACE/physmon
CI/physmon/generate_comment.py $GITHUB_WORKSPACE/physmon comment.md
echo "# 📊: Physics performance monitoring for ${PR_SHA}" >> comment.md
echo "[Full contents](${ARTIFACT_URL})" >> comment.md
if [ -f "$GITHUB_WORKSPACE/physmon/summary.md" ]; then
cat $GITHUB_WORKSPACE/physmon/summary.md >> comment.md
else
echo "🟥 summary not found!" >> comment.md
fi
cat comment.md
- name: Find Comment
Expand Down
167 changes: 0 additions & 167 deletions CI/physmon/comment_template.md

This file was deleted.

100 changes: 0 additions & 100 deletions CI/physmon/generate_comment.py

This file was deleted.

0 comments on commit 3f4cbab

Please sign in to comment.