Skip to content

Commit

Permalink
refactor: correct phi and theta for periodicity changes in KalmanVert…
Browse files Browse the repository at this point in the history
…exUpdater (#2769)

will break athena
  • Loading branch information
felix-russo authored Jan 25, 2024
1 parent b0432e5 commit d095879
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions Core/src/Vertexing/KalmanVertexUpdater.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,6 @@ double trackParametersChi2(
Vector3 newTrkMom = cache.wMat * momJac.transpose() * trkParamWeight *
(trkParams - constTerm - posJacVtxPos);

// Correct phi and theta for possible periodicity changes
// Commented out because of broken ATHENA tests.
// TODO: uncomment
/*
const auto correctedPhiTheta =
Acts::detail::normalizePhiTheta(newTrkMom(0), newTrkMom(1));
newTrkMom(0) = correctedPhiTheta.first; // phi
newTrkMom(1) = correctedPhiTheta.second; // theta
*/

// \tilde{p_k}
ParameterVector linearizedTrackParameters =
constTerm + posJacVtxPos + momJac * newTrkMom;
Expand Down

0 comments on commit d095879

Please sign in to comment.