Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad physmon results if interactions enabled in Fatras #1643

Closed
benjaminhuth opened this issue Nov 1, 2022 · 2 comments
Closed

Bad physmon results if interactions enabled in Fatras #1643

benjaminhuth opened this issue Nov 1, 2022 · 2 comments
Labels
Stale

Comments

@benjaminhuth
Copy link
Member

Until now, all interactions are disabled by default in Fatras. Enabling them causes quite some bad results in the physmon for some setups (see plots in #1631).
What should be the next steps to investigate this?
@stale
Copy link

stale bot commented May 9, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label May 9, 2023
@andiwand andiwand mentioned this issue May 9, 2023
Merged
kodiakhq bot pushed a commit that referenced this issue Jul 24, 2023
@andiwand
fix: Improve full chain pulls by enabling Fatras interactions (#2086)
dbcba62 
Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution.

Fixes
- #1643

Blocked by
- #2157
- #2239
- #2295
- #2293
- #2294
paulgessinger pushed a commit to paulgessinger/acts that referenced this issue Jul 24, 2023
@andiwand @paulgessinger
fix: Improve full chain pulls by enabling Fatras interactions (acts-p…
9e75691 
…roject#2086)

Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution.

Fixes
- acts-project#1643

Blocked by
- acts-project#2157
- acts-project#2239
- acts-project#2295
- acts-project#2293
- acts-project#2294
@paulgessinger
Copy link
Member

I think with #2086 we can consider this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulgessinger @benjaminhuth