Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagation state cannot be initialized outside the propagation #2736

Open
andiwand opened this issue Nov 28, 2023 · 1 comment
Open

Propagation state cannot be initialized outside the propagation #2736

andiwand opened this issue Nov 28, 2023 · 1 comment
Labels

Comments

@andiwand
Copy link
Contributor

Currently the propagation state which incorporated the navigator and stepper state cannot be initialized outside the propagation. This is not optimal for externalSurfaces in the Navigator or the list of surfaces in the DirectNavigator. Currently we hack our way around that by setting the state via code in the actor that only get executed once.

Listing some code consequences here:

My proposed solution is to decouple the propagation state creation from the propagate call #2552

Apart from that it would be beneficial IMO to move some of the state properties or config properties into an option struct that is part of the PropagationOptions and can be set for each propagation individually.

Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant