refactor: Move actor state into propagator state

[andiwand]

I propose to move the actor state into the propagator state. This allows us to copy the whole propagator state and to start the propagation from a specific state after it stopped before.

Intention of this change is that algorithms may want to steer the propagation from the outside rather than from within by using an actor.

[github-actions]

📊: Physics performance monitoring for f069ea4

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[andiwand]

@paulgessinger @benjaminhuth @asalzburger do you have some early feedback on this?

[codecov]

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (9f4a569) 49.03% compared to head (f069ea4) 49.03%.

Files	Patch %	Lines
Core/include/Acts/Propagator/Propagator.ipp	46.00%	3 Missing and 24 partials ⚠️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp	35.29%	0 Missing and 11 partials ⚠️
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	33.33%	0 Missing and 4 partials ⚠️
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp	33.33%	0 Missing and 4 partials ⚠️
Core/include/Acts/TrackFitting/KalmanFitter.hpp	25.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   49.03%   49.03%   -0.01%     
==========================================
  Files         492      492              
  Lines       28526    28542      +16     
  Branches    13477    13487      +10     
==========================================
+ Hits        13989    13995       +6     
  Misses       4819     4819              
- Partials     9718     9728      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paulgessinger]

There are a number of cases where I wonder if you need to supply the explicit template parameters of you could let the compiler figure them out. Did you try this out?

Other than that, do you need the template if you don't supply explicit arguments? I thought this is just needed to disambiguate what <> means syntactically.

[andiwand]

There are a number of cases where I wonder if you need to supply the explicit template parameters of you could let the compiler figure them out. Did you try this out?

Other than that, do you need the template if you don't supply explicit arguments? I thought this is just needed to disambiguate what <> means syntactically.

big thanks for your comments @paulgessinger ! I am cleaning this out

[asalzburger]

I am happy with it now.

[paulgessinger]

Found one more case, but not critical

[acts-project-service]

🔴 Athena integration test results [6f8e9b8]

Build job with this PR failed!

Please investigate the build job for the pipeline!