feat: GX2F (Global Chi2 Fitter) | Gχ²F #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearrange and spelling
AJPfleger
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 48.58% 48.54% -0.05%
==========================================
Files 381 384 +3
Lines 20833 21041 +208
Branches 9557 9693 +136
==========================================
+ Hits 10122 10214 +92
+ Misses 4108 4105 -3
- Partials 6603 6722 +119
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
reviewed
Oct 27, 2022
asalzburger
approved these changes
Nov 1, 2022
|
I'll merge this manually when the CI completes, so we can properly add a reference to @r4lv in the commit. |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
…cts-project#2302) Clean removal of my old gx2f implementation from PR acts-project#1580 to make space for my new implementation. The new one will work, I promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clean PR for the GX2F. This is the completion of PR #1099 since, some segfaults on mac were causing problems (read there for more info on that issue).
The GX2F consists now of:
Chi2Fitter.hppUpdate 2022-10-26: We found a second segfault and fixed it with this commit
Update 2022-10-28: move to namespace
ExperimentalUpdate 2022-10-31: adapt for PR #1512 (thank you @paulgessinger)
Update 2022-10-31: adapt for PR #1610