feat: configurable maximum number of bins in SP grid

[LuisFelipeCoelho]

Protection for large number of bins which is set by default to std::numeric_limits<int>::max()

This comes from PR #2166, I am splitting the changes into smaller PRs.
@CarloVarni

[codecov]

Codecov Report

Merging #2325 (4a95ff9) into main (10b40b7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2325      +/-   ##
==========================================
- Coverage   49.64%   49.63%   -0.01%     
==========================================
  Files         453      453              
  Lines       25538    25540       +2     
  Branches    11708    11709       +1     
==========================================
  Hits        12678    12678              
- Misses       4578     4580       +2     
  Partials     8282     8282              

Files Changed	Coverage Δ
Core/include/Acts/Seeding/SpacePointGrid.ipp	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 4a95ff9

Full contents

physmon summary

• ✅ Ambisolver orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver
• ✅ AMVF orthogonal
• ✅ AMVF seeded
• ✅ AMVF truth_estimated
• ✅ AMVF truth_smeared
• ✅ AMVF ttbar
• ✅ CKF orthogonal
• ✅ CKF seeded
• ✅ CKF truth_estimated
• ✅ CKF truth_smeared
• ✅ CKF ttbar
• ✅ Truth tracking (GSF)
• ✅ IVF orthogonal
• ✅ IVF seeded
• ✅ IVF truth_estimated
• ✅ IVF truth_smeared
• ✅ Particles final fatras
• ✅ Particles final geant4
• ✅ Particles inital fatras
• ✅ Particles inital geant4
• ✅ Seeding orthogonal
• ✅ Seeding seeded
• ✅ Seeding truth_estimated
• ✅ Seeding ttbar
• ✅ Track Summary CKF orthogonal
• ✅ Track Summary CKF seeded
• ✅ Track Summary CKF truth_estimated
• ✅ Track Summary CKF truth_smeared
• ✅ Truth tracking

[paulgessinger]

Looks good overall, only spotted one inconsistency with the (now changed) default of 300. I don't have a strong opinion on the default. I guess infinite is a bit dangerous since you could potentially try to allocate infinite memory that way, although I suppose it's bounded by the event activity.

I'd probably pick a "large but not infinite" number, like mayb 10k or so and then mention that in the comment.

Up to you @LuisFelipeCoelho.

[paulgessinger]

Somehow the clang-tidy job seems to get stuck repeatedly, in that it's result isn't posted back here. It's only that job it seems though, which is weird.

[acts-project-service]

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🔴	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data

[paulgessinger]

Failure is unrelated to us.