Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Experiment cuts to dublets in seed finder #2326

Merged
merged 32 commits into from
Nov 24, 2023

Conversation

LuisFelipeCoelho
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho commented Jul 27, 2023

This PR adds an option to include experimental specific cuts to discard bottom-middle dublets in a certain (r, eta) region of the detector.

This PR is related to the implementation of the ITk "fast tracking" configuration from PR #2166
(I am splitting the changes to make it more organised @CarloVarni @noemina)

For the integration with Athena we will need to implement something like that in Athena:

m_finderCfg.experimentCuts.connect(
	[](const void*, const float& bottomRadius, const float& cotTheta) -> bool {

        if (bottomRadius < fastTrackingRMin and
               (cotTheta > fastTrackingCotThetaMax or
                cotTheta < -fastTrackingCotThetaMax)) {
             return false;
        }
        return true;
}

where:

float fastTrackingRMin = 50. * Acts::UnitConstants::mm;
float fastTrackingCotThetaMax = 1.5;

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d6b8266) 49.52% compared to head (dd3f1c5) 49.50%.
Report is 1 commits behind head on main.

❗ Current head dd3f1c5 differs from pull request most recent head 8077bff. Consider uploading reports for the commit 8077bff to get more accurate results

Files Patch % Lines
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% 5 Missing ⚠️
...clude/Acts/Seeding/SeedConfirmationRangeConfig.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   49.52%   49.50%   -0.02%     
==========================================
  Files         474      475       +1     
  Lines       26968    26975       +7     
  Branches    12452    12454       +2     
==========================================
  Hits        13355    13355              
- Misses       4755     4762       +7     
  Partials     8858     8858              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LuisFelipeCoelho and others added 3 commits July 28, 2023 11:18
Co-authored-by: Carlo Varni <75478407+CarloVarni@users.noreply.github.com>
Co-authored-by: Carlo Varni <75478407+CarloVarni@users.noreply.github.com>
@github-actions github-actions bot added the Stale label Sep 22, 2023
@paulgessinger paulgessinger added this to the next milestone Sep 29, 2023
@github-actions github-actions bot removed Component - Examples Affects the Examples module Track Finding labels Oct 30, 2023
@LuisFelipeCoelho LuisFelipeCoelho changed the title feat: experiment cuts to dublets in seed finder feat: Experiment cuts to dublets in seed finder Nov 15, 2023
@LuisFelipeCoelho
Copy link
Member Author

Thank you @paulgessinger for the suggestion, I think this is finally working

@kodiakhq kodiakhq bot merged commit f32f90f into acts-project:main Nov 24, 2023
48 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants