Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unit test amvfitter #2530

Merged
merged 14 commits into from
Nov 10, 2023

Conversation

felix-russo
Copy link
Contributor

@felix-russo felix-russo commented Oct 11, 2023

  • Reactivate checks in the unit test of AMVFitter that were commented out.
  • Use logger in the unit test of AMVFitter.

@github-actions github-actions bot added Component - Core Affects the Core module Vertexing labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2530 (cf8b7c3) into main (b5e71d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2530   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files         473      473           
  Lines       26833    26833           
  Branches    12357    12357           
=======================================
  Hits        13311    13311           
  Misses       4753     4753           
  Partials     8769     8769           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@paulgessinger paulgessinger added this to the next milestone Oct 23, 2023
@felix-russo felix-russo marked this pull request as ready for review October 24, 2023 12:04
@kodiakhq kodiakhq bot merged commit 2747183 into acts-project:main Nov 10, 2023
53 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 10, 2023

🔴 Athena integration test results [2747183]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 10, 2023
@felix-russo felix-russo deleted the unit-test-amvfitter branch November 12, 2023 13:20
@paulgessinger
Copy link
Member

I think the output failures are bogus. Checking if they're fixed now.

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Nov 14, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 15, 2023
@paulgessinger paulgessinger removed Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants