-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove division of vertex covariance with weight #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2551 +/- ##
=======================================
Coverage 49.60% 49.61%
=======================================
Files 471 471
Lines 26695 26693 -2
Branches 12284 12282 -2
=======================================
+ Hits 13242 13243 +1
Misses 4747 4747
+ Partials 8706 8703 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
changed the title
refactor: remove division of vertex covariance with weight
refactor!: remove division of vertex covariance with weight
Oct 23, 2023
andiwand
previously approved these changes
Oct 23, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Oct 25, 2023
paulgessinger
approved these changes
Oct 25, 2023
paulgessinger
added
Breaks Athena build
This PR breaks the Athena build
Fails Athena tests
This PR causes a failure in the Athena tests
and removed
Fails Athena tests
This PR causes a failure in the Athena tests
labels
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Fails Athena tests
This PR causes a failure in the Athena tests
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #2522 which we had to revert due to athena output changes
Should go in for the next major version